Rancher node checks correction #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KiranBodipi
commented
Feb 8, 2024
•
KiranBodipi
commented
- Have modified test criteria such that it produces right output in case of there is no file exists.
- Have modified the tests wherever root:root is checked both in flag and value.
mjshastha
reviewed
Feb 9, 2024
cfg/rke-cis-1.24/node.yaml
Outdated
| tests: | ||
| bin_op: or | ||
| test_items: | ||
| - flag: root:root | ||
| compare: |
There was a problem hiding this comment.
@KiranBodipi You missed to remove the comparison operation here.
1. Have modified test criteria such that it produces right output in case of there is no file exists. 2. Have modified the tests wherever root:root is checked multiple times.
KiranBodipi
force-pushed
the
kb-rke-checks-correction
branch
from
3158b9d
to
54d34b0
Compare
mjshastha
approved these changes
Feb 9, 2024
deven0t
approved these changes
Feb 12, 2024
|
Hey @chen-keinan could you please help to review and merge the PR. |
chen-keinan
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.